sql: add schema descriptions as table and column comments #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaac-sec
force-pushed
the
isaac/desc-comments
branch
3 times, most recently
from
a7d0852 to
cf4928c
Compare
|
The original code was broken. I pushed an update with an approach that does work by hooking foreign table creation and adding comments with the descriptions immediately after it is executed. |
The steampipe CLI does this, and it's very helpful when trying to figure out what a specific table or column holds.
isaac-sec
force-pushed
the
isaac/desc-comments
branch
from
cf4928c to
ea66ac2
Compare
|
Thanks @isaac-sec for the contribution, we will take a look into this! |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The steampipe CLI does this, and it's very helpful when trying to figure out what a specific table or column holds.